Bug 2043229 - Display a "Show External" button beneath attachments list to display all attachments that would redirect such as Github and Phabricator#2633
Open
dklawren wants to merge 4 commits into
Conversation
…st to display all attachments that would redirect such as Github and Phabricator
There was a problem hiding this comment.
Pull request overview
Adds a "Show External" toggle to the BugModal attachments list that hides attachments whose MIME types match a new configurable parameter (attachment_hide_content_types), defaulting to GitHub PR and Phabricator request types. External rows are rendered hidden by default and toggled by a new footer button, mirroring the existing obsolete-toggle behavior.
Changes:
- New
attachment_hide_content_typesparam (text list of MIME types) with sensible default inBugzilla/Config/Attachment.pm. - BugModal templates count, class, and conditionally hide external attachments, and render a new "Show External" button alongside "Show Obsolete".
- BugModal JS refactors the obsolete toggle into shared state plus a new external toggle in
updateAttachmentRows().
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
Bugzilla/Config/Attachment.pm |
Adds the attachment_hide_content_types parameter with default GitHub/Phabricator types. |
extensions/BugModal/template/en/default/bug_modal/edit.html.tmpl |
Parses the param, counts external attachments, and forwards them to the attachments include. |
extensions/BugModal/template/en/default/bug_modal/attachments.html.tmpl |
Tags rows with attach-external, hides them by default, and adds the "Show External" button. |
extensions/BugModal/web/bug_modal.js |
Replaces single-state obsolete toggle with combined obsolete/external state and toggle handlers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.